X-Git-Url: https://ruin.nu/git/?a=blobdiff_plain;f=covop.pl;h=a07c47f39fa095f66cd6b1c42e34044ecf4380d0;hb=03830799201db0b0f28e9c494fdd1b5b5143749c;hp=9c8284d33ddeba4ec3f11b654268045e8d885bec;hpb=9e7bc0a25ae14affe960a0606d0542677c51abd7;p=ndwebbie.git

diff --git a/covop.pl b/covop.pl
index 9c8284d..a07c47f 100644
--- a/covop.pl
+++ b/covop.pl
@@ -18,25 +18,25 @@
 #**************************************************************************/
 
 use strict;
+use warnings FATAL => 'all';
 
 $ND::TEMPLATE->param(TITLE => 'CovOp Targets');
 
 our $BODY;
 our $DBH;
-our $LOG;
 
 die "You don't have access" unless isMember();
 
 my $show = q{AND ((planet_status IS NULL OR NOT planet_status IN ('Friendly','NAP')) AND  (relationship IS NULL OR NOT relationship IN ('Friendly','NAP')))};
-$show = '' if param('show') eq 'all';
-if (param('covop') =~ /^(\d+)$/){
+$show = '' if defined param('show') && param('show') eq 'all';
+if (defined param('covop') && param('covop') =~ /^(\d+)$/){
 	my $update = $DBH->prepare('UPDATE covop_targets SET covop_by = ?, last_covop = tick() WHERE planet = ? ');
 	$update->execute($ND::UID,$1);
 }
 
 my $list = '';
 my $where = '';
-if (param('list') eq 'distwhores'){
+if (defined param('list') && param('list') eq 'distwhores'){
 	$list = '&list=distwhores';
 	$where = qq{WHERE dists > 0 $show
 ORDER BY dists DESC,COALESCE(sec_centres::float/structures*100,0)ASC}
@@ -59,10 +59,10 @@ $query->execute($ND::PLANET);
 my @targets;
 my $i = 0;
 while (my ($id,$coords,$metal,$crystal,$eonium,$seccents,$dists,$lastcovop,$user,$max) = $query->fetchrow){
+	$i++;
 	push @targets,{Username => $user, Target => $id, Coords => $coords
 		, Metal => $metal, Crystal => $crystal, Eonium => $eonium, SecCents => $seccents
 		, Dists => $dists, MaxResHack => $max, LastCovOp => $lastcovop, List => $list, ODD => $i % 2};
-	$i++;
 }
 $BODY->param(Targets => \@targets);