From: Michael Andreen <harv@ruin.nu>
Date: Fri, 29 Dec 2006 16:55:52 +0000 (+0000)
Subject: more fatal warnings
X-Git-Url: https://ruin.nu/git/?a=commitdiff_plain;h=af2d229a9ccf779d06fc338c4f429f75e69dd7d2;p=ndwebbie.git

more fatal warnings
---

diff --git a/addintel.pl b/addintel.pl
index 28d7d0e..5e65ad7 100644
--- a/addintel.pl
+++ b/addintel.pl
@@ -19,7 +19,6 @@
 
 use strict;
 use warnings FATAL => 'all';
-no warnings qw(uninitialized);
 
 $ND::TEMPLATE->param(TITLE => 'Add Intel and Scans');
 
@@ -30,43 +29,45 @@ my $error;
 
 die "You don't have access" unless isMember();
 
-if (param('cmd') eq 'submit' || param('cmd') eq 'submit_message'){
-	my $findscan = $DBH->prepare("SELECT scan_id FROM scans WHERE scan_id = ? AND tick >= tick() - 48");
-	my $addscan = $DBH->prepare('INSERT INTO scans (scan_id,tick,"type") VALUES (?,tick(),?)');
-	my $addpoint = $DBH->prepare('UPDATE users SET scan_points = scan_points + 1 WHERE uid = ? ');
-	my $intel = param('intel');
-	my @scans;
-	while ($intel =~ m/http:\/\/game.planetarion.com\/showscan.pl\?scan_id=(\d+)/g){
-		my %scan;
-		$scan{Scan} = $1;
-		$scan{Message} = "Scan $1: ";
-		$findscan->execute($1);
-		if ($findscan->rows == 0){
-			if ($addscan->execute($1,$ND::UID)){
-				$addpoint->execute($ND::UID);
-				$scan{Message} .= '<i>added</i>';
+if (defined param('cmd')){
+	if (param('cmd') eq 'submit' || param('cmd') eq 'submit_message'){
+		my $findscan = $DBH->prepare("SELECT scan_id FROM scans WHERE scan_id = ? AND tick >= tick() - 48");
+		my $addscan = $DBH->prepare('INSERT INTO scans (scan_id,tick,"type") VALUES (?,tick(),?)');
+		my $addpoint = $DBH->prepare('UPDATE users SET scan_points = scan_points + 1 WHERE uid = ? ');
+		my $intel = param('intel');
+		my @scans;
+		while ($intel =~ m/http:\/\/game.planetarion.com\/showscan.pl\?scan_id=(\d+)/g){
+			my %scan;
+			$scan{Scan} = $1;
+			$scan{Message} = "Scan $1: ";
+			$findscan->execute($1);
+			if ($findscan->rows == 0){
+				if ($addscan->execute($1,$ND::UID)){
+					$addpoint->execute($ND::UID);
+					$scan{Message} .= '<i>added</i>';
+				}else{
+					$scan{Message} .= "<b>something went wrong:</b> <i>$DBH->errstr</i>";
+				}
 			}else{
-				$scan{Message} .= "<b>something went wrong:</b> <i>$DBH->errstr</i>";
-			}
-		}else{
 				$scan{Message} .= '<b>already exists</b>';
+			}
+			push @scans,\%scan;
+		}
+		$BODY->param(Scans => \@scans);
+		my $tick = $ND::TICK;
+		$tick = param('tick') if $tick =~ /^(\d+)$/;
+		my $addintel = $DBH->prepare(qq{SELECT add_intel(?,?,?,?,?,?,?,?,?,?,?)});
+		while ($intel =~ m/(\d+):(\d+):(\d+)\*?\s+(\d+):(\d+):(\d+)\*?\s+.+(?:Ter|Cat|Xan|Zik)?\s+(\d+)\s+(Attack|Defend)\s+(\d+)/g){
+			$addintel->execute($tick,$9, $1,$2,$3,$4,$5,$6,$7,$8,$ND::UID) or $error .= $DBH->errstr;
 		}
-		push @scans,\%scan;
-	}
-	$BODY->param(Scans => \@scans);
-	my $tick = $ND::TICK;
-	$tick = param('tick') if $tick =~ /^(\d+)$/;
-	my $addintel = $DBH->prepare(qq{SELECT add_intel(?,?,?,?,?,?,?,?,?,?,?)});
-	while ($intel =~ m/(\d+):(\d+):(\d+)\*?\s+(\d+):(\d+):(\d+)\*?\s+.+(?:Ter|Cat|Xan|Zik)?\s+(\d+)\s+(Attack|Defend)\s+(\d+)/g){
-		$addintel->execute($tick,$9, $1,$2,$3,$4,$5,$6,$7,$8,$ND::UID) or $error .= $DBH->errstr;
 	}
-}
-if (param('cmd') eq 'submit_message'){
-	my $query = $DBH->prepare(q{INSERT INTO intel_messages (uid,message) VALUES(?,?)});
-	if($query->execute($ND::UID,escapeHTML(param('intel')))){
-		$error .= 'Intel messaged added';
-	}else{
-		$error .= $DBH->errstr;
+	if (param('cmd') eq 'submit_message'){
+		my $query = $DBH->prepare(q{INSERT INTO intel_messages (uid,message) VALUES(?,?)});
+		if($query->execute($ND::UID,escapeHTML(param('intel')))){
+			$error .= 'Intel messaged added';
+		}else{
+			$error .= $DBH->errstr;
+		}
 	}
 }
 $BODY->param(Tick => $ND::TICK);