more fatal warnings and other cleanup

[ndwebbie.git] / covop.pl

diff --git a/covop.pl b/covop.pl
index 9c8284d33ddeba4ec3f11b654268045e8d885bec..daf782458281a2e46a1257e236415e101f66c2fe 100644 (file)
--- a/covop.pl
+++ b/covop.pl
@@ -18,6 +18,7 @@
 #**************************************************************************/
 
 use strict;
+use warnings FATAL => 'all';
 
 $ND::TEMPLATE->param(TITLE => 'CovOp Targets');
 
@@ -28,15 +29,15 @@ our $LOG;
 die "You don't have access" unless isMember();
 
 my $show = q{AND ((planet_status IS NULL OR NOT planet_status IN ('Friendly','NAP')) AND  (relationship IS NULL OR NOT relationship IN ('Friendly','NAP')))};
-$show = '' if param('show') eq 'all';
-if (param('covop') =~ /^(\d+)$/){
+$show = '' if defined param('show') && param('show') eq 'all';
+if (defined param('covop') && param('covop') =~ /^(\d+)$/){
        my $update = $DBH->prepare('UPDATE covop_targets SET covop_by = ?, last_covop = tick() WHERE planet = ? ');
        $update->execute($ND::UID,$1);
 }
 
 my $list = '';
 my $where = '';
-if (param('list') eq 'distwhores'){
+if (defined param('list') && param('list') eq 'distwhores'){
        $list = '&list=distwhores';
        $where = qq{WHERE dists > 0 $show
 ORDER BY dists DESC,COALESCE(sec_centres::float/structures*100,0)ASC}
@@ -59,10 +60,10 @@ $query->execute($ND::PLANET);
 my @targets;
 my $i = 0;
 while (my ($id,$coords,$metal,$crystal,$eonium,$seccents,$dists,$lastcovop,$user,$max) = $query->fetchrow){
+       $i++;
        push @targets,{Username => $user, Target => $id, Coords => $coords
                , Metal => $metal, Crystal => $crystal, Eonium => $eonium, SecCents => $seccents
                , Dists => $dists, MaxResHack => $max, LastCovOp => $lastcovop, List => $list, ODD => $i % 2};
-       $i++;
 }
 $BODY->param(Targets => \@targets);