order by last post

[ndwebbie.git] / users.pl

diff --git a/users.pl b/users.pl
index 20687a5ca4efad6f794b01de4a25c5ea2e42deb8..ba87e920b190bf488eb68e972125612711895e69 100644 (file)
--- a/users.pl
+++ b/users.pl
@@ -19,11 +19,9 @@
 
 use strict;
 use warnings FATAL => 'all';
-no warnings qw(uninitialized);
-use POSIX;
+use ND::Include;
 our $BODY;
 our $DBH;
-our $LOG;
 
 $ND::TEMPLATE->param(TITLE => 'Users');
 
@@ -31,7 +29,7 @@ die "You don't have access" unless isHC();
 
 my $error = '';
 my $user;
-if (param('user') =~ /^(\d+)$/){
+if (defined param('user') && param('user') =~ /^(\d+)$/){
        my $query = $DBH->prepare(q{
 SELECT uid,username,hostmask,coords(x,y,z) AS planet,attack_points,defense_points,scan_points,humor_points  
        FROM users u LEFT OUTER JOIN current_planet_stats p ON u.planet = p.id
@@ -41,7 +39,7 @@ WHERE uid = ?;
 }
 
 
-if ($user && param('cmd') eq 'change'){
+if ($user && defined param('cmd') && param('cmd') eq 'change'){
        $DBH->begin_work;
        for my $param (param()){
                if ($param =~ /^c:(\w+)$/){
@@ -59,7 +57,7 @@ if ($user && param('cmd') eq 'change'){
                        if ($DBH->do(qq{UPDATE users SET $column = ? WHERE uid = ? }
                                        ,undef,$value,$user->{uid})){
                                $user->{$column} = param($column);
-                               $LOG->execute($ND::UID,"HC set $column to $value for user: $user->{uid}");
+                               log_message $ND::UID,"HC set $column to $value for user: $user->{uid}";
                        }else{
                                $error .= "<p> Something went wrong: ".$DBH->errstr."</p>";
                        }
@@ -79,7 +77,9 @@ if ($user && param('cmd') eq 'change'){
                }
                if ($query){
                        if ($query->execute($user->{uid},$group->{gid})){
-                               $LOG->execute($ND::UID,"HC added user: $user->{uid} to group: $group->{gid}");
+                               my ($action,$a2) = ('added','to');
+                               ($action,$a2) = ('removed','from') if param($group->{gid}) eq 'remove';
+                               log_message $ND::UID,"HC $action user: $user->{uid} ($user->{username}) $a2 group: $group->{gid} ($group->{groupname})";
                        }else{
                                $error .= "<p> Something went wrong: ".$DBH->errstr."</p>";
                        }